Re: [BUG][tip/master] kernel panic while locking selftest at qspinlock_paravirt.h:137!

From: Ingo Molnar
Date: Fri Jul 10 2015 - 09:58:07 EST



* Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> On Fri, Jul 10, 2015 at 08:32:46PM +0900, Masami Hiramatsu wrote:
>
> > double unlock:
> > ------------[ cut here ]------------
> > kernel BUG at /home/mhiramat/ksrc/linux-3/kernel/locking/qspinlock_paravirt.h:137!
>
> > Call Trace:
> > [<ffffffff81114a59>] __raw_callee_save___pv_queued_spin_unlock+0x11/0x1e
> > [<ffffffff81117133>] ? do_raw_spin_unlock+0xfa/0x10c
> > [<ffffffff817cd3f7>] _raw_spin_unlock+0x44/0x64
> > [<ffffffff814603ee>] double_unlock_spin+0x3d/0x46
>
> Cute, but somewhat expected. A double unlock really is a BUG and the PV
> spinlock code cannot deal with it.
>
> Do we want to make double unlock non-fatal unconditionally?

No, just don't BUG() out, don't crash the system - generate a warning?

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/