Re: [PATCH v4 0/3] net: dsa: mv88e6xxx: add support for VLAN Table Unit

From: Vivien Didelot
Date: Thu Jul 09 2015 - 17:03:45 EST


Hi David,

----- On Jul 9, 2015, at 2:01 PM, David davem@xxxxxxxxxxxxx wrote:

> From: Vivien Didelot <vivien.didelot@xxxxxxxxxxxxxxxxxxxx>
> Date: Wed, 8 Jul 2015 13:13:16 -0400 (EDT)
>
>> You're right. There's a single operation to clear the STU and VTU. I
>> will send a follow-up patch to send this command during the switch
>> setup.
>
> Fix known bugs in the patch series, within the patch series, since it
> hasn't been merged yet.
>
> Don't say "I'll fix this bug later", because we can fix it now.
>
> Also as others have noted, this patch set creates an intermediate
> state where functionality is effectively broken. So it is illogical
> to knowingly merge this patch series as-is. You'll have to piece
> together all of the changes necessary such that the series is fully
> bisectable, which means at every patch along the way things function
> properly and do not break.

Dully noted.

Thank you,
-v
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/