Re: [PATCH 3/4] mm, oom: organize oom context into struct

From: Michal Hocko
Date: Thu Jul 09 2015 - 04:56:13 EST


On Wed 08-07-15 16:38:25, David Rientjes wrote:
> On Wed, 8 Jul 2015, Michal Hocko wrote:
>
> > From: David Rientjes <rientjes@xxxxxxxxxx>
> >
> > There are essential elements to an oom context that are passed around to
> > multiple functions.
> >
> > Organize these elements into a new struct, struct oom_context, that
> > specifies the context for an oom condition.
> >
> > This patch introduces no functional change.
> >
> > [mhocko@xxxxxxx: s@oom_control@oom_context@]
> > [mhocko@xxxxxxx: do not initialize on stack oom_context with NULL or 0]
> > Signed-off-by: David Rientjes <rientjes@xxxxxxxxxx>
> > Signed-off-by: Michal Hocko <mhocko@xxxxxxx>
>
> I hate to appear to be nacking my own patch, but it was correct when
> included in my series

What is incorrect in this patch?
--
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/