Re: [RFC PATCH v3 1/4] STM trace event: Adding generic buffer interface driver

From: Peter Zijlstra
Date: Wed Jul 08 2015 - 08:10:44 EST


On Tue, Jul 07, 2015 at 06:10:40PM +0800, Chunyan Zhang wrote:
> +config STM_TRACE_EVENT
> + tristate "Redirect/copy the output from kernel trace event to STM engine"

How does tristate make sense here? You're using it unconditionally for
in-kernel tracepoints. This must be bool, which in turn makes the whole
STM thing bool afaiu.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/