Re: [PATCH v2] watchdog: omap_wdt: early_enable module parameter

From: Paul Gortmaker
Date: Tue Jun 30 2015 - 01:57:22 EST


On Thu, Jun 25, 2015 at 9:46 AM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
> On 06/25/2015 03:21 AM, poeschel@xxxxxxxxxxx wrote:
>>
>> From: Lars Poeschel <poeschel@xxxxxxxxxxx>
>>
>> Add a early_enable module parameter to the omap_wdt that starts the
>> watchdog on module insertion. The default value is 0 which does not
>> start the watchdog - which also does not change the behavior if the
>> parameter is not given.
>>
>> Signed-off-by: Lars Poeschel <poeschel@xxxxxxxxxxx>
>
>
> Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

In case the info hasn't looped back around yet, this breaks the
omap builds in linux-next:

drivers/watchdog/omap_wdt.c:288:18: error: 'omap_wdt' undeclared
(first use in this function)

(Not sure how this could have ever worked as-is.)

http://kisskb.ellerman.id.au/kisskb/buildresult/12452335/

I see a patch has already been posted to arm-kernel but not
Cc'd to all originally involved so figured I'd mention it.

Paul.
--

>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/