Re: [PATCH 04/15] libnvdimm, nfit, nd_blk: driver for BLK-mode access persistent memory

From: Dan Williams
Date: Sun Jun 21 2015 - 09:31:52 EST


On Sun, Jun 21, 2015 at 3:05 AM, Christoph Hellwig <hch@xxxxxx> wrote:
>> +#include <asm-generic/io-64-nonatomic-hi-lo.h>
>
> As mentioned last time only arch asm/ headers may include asm-generic
> headers.

No, not in this case, there's no other way to define readq()/writeq()
on 32-bit builds. See:

drivers/block/nvme-core.c:43:#include <asm-generic/io-64-nonatomic-lo-hi.h>
drivers/edac/i3200_edac.c:18:#include <asm-generic/io-64-nonatomic-lo-hi.h>
drivers/edac/ie31200_edac.c:42:#include <asm-generic/io-64-nonatomic-lo-hi.h>
drivers/edac/x38_edac.c:18:#include <asm-generic/io-64-nonatomic-lo-hi.h>
drivers/i2c/busses/i2c-ismt.c:70:#include <asm-generic/io-64-nonatomic-lo-hi.h>
drivers/net/ethernet/intel/i40e/i40e_osdep.h:38:#include
<asm-generic/io-64-nonatomic-lo-hi.h>
drivers/net/ethernet/intel/i40evf/i40e_osdep.h:37:#include
<asm-generic/io-64-nonatomic-lo-hi.h>
drivers/net/ethernet/rocker/rocker.c:39:#include
<asm-generic/io-64-nonatomic-lo-hi.h>
drivers/platform/x86/ibm_rtl.c:36:#include <asm-generic/io-64-nonatomic-lo-hi.h>
drivers/platform/x86/intel_ips.c:81:#include
<asm-generic/io-64-nonatomic-lo-hi.h>
drivers/scsi/qla4xxx/ql4_nx.c:15:#include <asm-generic/io-64-nonatomic-lo-hi.h>

The only other option is to open code multiple readl() + writel() calls.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/