Re: [PATCH 10/10] x86/intel_rdt: Intel haswell Cache Allocation enumeration

[Vikas Shivappa]

On Mon, 15 Jun 2015, Peter Zijlstra wrote:

> On Fri, Jun 12, 2015 at 11:17:17AM -0700, Vikas Shivappa wrote:
> > +	/*
> > +	 * Probe test for Haswell CPUs.
> > +	 */
> > +	if (c->x86 == 0x6 && c->x86_model == 0x3f)
> > +		return hsw_probetest();
>
> Firstly, isn't a probe already a test?

Will fix the name to hsw_probe

> Secondly, there's more HSW models:
>
>        case 60: /* 22nm Haswell Core */
>        case 63: /* 22nm Haswell Server */
>        case 69: /* 22nm Haswell ULT */
>        case 70: /* 22nm Haswell + GT3e (Intel Iris Pro graphics) */
>
> Is this really only HSW server,

Yes , this probe is only targeted at HSW servers as of now.

or should they all be listed?
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/