RE: [PATCH v2 4/6] drivers:hv: Export a function that maps Linux proc num onto Hyper-V proc num

[Jake Oshins]

> -----Original Message-----
> From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx]
> Sent: Monday, June 15, 2015 12:52 PM
> To: Jake Oshins
> Cc: KY Srinivasan; linux-kernel@xxxxxxxxxxxxxxx;
> devel@xxxxxxxxxxxxxxxxxxxxxx; olaf@xxxxxxxxx; apw@xxxxxxxxxxxxx;
> vkuznets@xxxxxxxxxx; bhelgaas@xxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx;
> pebolle@xxxxxxxxxx; Haiyang Zhang; Mike Ebersol
> Subject: Re: [PATCH v2 4/6] drivers:hv: Export a function that maps Linux
> proc num onto Hyper-V proc num
> 
> > +/**
> > + * This function returns the mapping between the Linux processor
> > + * number and
> > + * the hypervisor's virtual processor number, useful in making
> > + * hypercalls and such that talk about specific processors.
> > + *
> > + * @param procnum - in Linux terms
> 
> What kind of comment structure is this?  It's not kernel doc :(
> 
> And "procnum" sounds like "process number", why not "cpu_number"?

Thanks.  I'll wait a little while to see if any other feedback comes in and then I'll fix these and resend.

-- Jake Oshins

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/