Re: [PATCH resend] cpumask: don't perform while loop in cpumask_next_and()

From: Peter Zijlstra
Date: Mon Jun 15 2015 - 09:12:38 EST


On Mon, Mar 02, 2015 at 12:22:03AM +0900, Sergey Senozhatsky wrote:

> +++ b/lib/cpumask.c
> @@ -37,10 +37,11 @@ EXPORT_SYMBOL(__next_cpu_nr);
> int cpumask_next_and(int n, const struct cpumask *src1p,
> const struct cpumask *src2p)
> {
> + struct cpumask tmp;
> +
> + if (cpumask_and(&tmp, src1p, src2p))
> + return cpumask_next(n, &tmp);
> + return nr_cpu_ids;
> }
> EXPORT_SYMBOL(cpumask_next_and);

Just ran into this; I though we were not supposed to put cpumasks on the
stack because $BIG. ?!

explain.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/