Re: [PATCH v3 01/10] tracing: Update cond flag when enabling or disabling a trigger

From: Daniel Wagner
Date: Sat Jun 13 2015 - 04:45:29 EST


On 06/12/2015 06:01 PM, Steven Rostedt wrote:

Why v3 in the subject?

This patch has not changed since v3 I guess.


On Mon, 8 Jun 2015 16:32:00 -0500
Tom Zanussi <tom.zanussi@xxxxxxxxxxxxxxx> wrote:

When a trigger is enabled, the cond flag should be set beforehand,
otherwise a trigger that's expecting to process a trace record
(e.g. one with post_trigger set) could be invoked without one.

Likewise a trigger's cond flag should be reset after it's disabled,
not before.

Signed-off-by: Tom Zanussi <tom.zanussi@xxxxxxxxxxxxxxx>
Signed-off-by: Daniel Wagner <daniel.wagner@xxxxxxxxxxxx>

Why is Daniel signed off by here?

I have reported the issue and send a fix for this patch

https://lkml.org/lkml/2015/4/21/161

I would have complained if I wasn't okay with it.

cheers,
daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/