Re: [PATCH 06/12] x86/mm: Enable and use the arch_pgd_init_late() method

From: Ingo Molnar
Date: Sat Jun 13 2015 - 02:51:44 EST



* Oleg Nesterov <oleg@xxxxxxxxxx> wrote:

> On 06/13, Oleg Nesterov wrote:
> >
> > Afaics, we need to ensure that:
> >
> > > + if (pgd_val(*pgd_src))
> > > + WRITE_ONCE(*pgd_dst, *pgd_src);
> >
> > either we notice the recent update of this PGD, or (say) the subsequent
> > sync_global_pgds() can miss the child.
>
> and perhaps !pgd_none(pgd_src) will look better.

Indeed - fixed.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/