Re: [PATCH] staging: comedi: replace ENOSYS by proper error codes

[Greg KH]

On Fri, Jun 12, 2015 at 10:06:16PM +0100, One Thousand Gnomes wrote:
> On Fri, 12 Jun 2015 13:43:27 -0700
> Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> 
> > On Fri, Jun 12, 2015 at 10:20:38PM +0200, julien.dehee@xxxxxxxxx wrote:
> > > From: Julien Dehee <julien.dehee@xxxxxxxxx>
> > > 
> > > comedi/comedi_fops.c
> > >     use ENODEV following open manual
> 
> That should probably be ENXIO by a strict reading, but Linux has always
> used ENODEV 8)
> 
> > > 
> > > comedi/drivers.c
> > >     use ENOTTY following ioctl manual
> > > 
> > > drivers/serial2002.c
> > >     use ENOTTY following ioctl manual
> > 
> > What do you mean by "ioctl manual"?
> 
> man 2 ioctl
> 
> Unknown ioctls on a device should error with ENOTTY. It's one of
> those crazy pieces of Unix history.

Note that the man 2 ioctl interface is not always what the kernel
exposes, but rather, what your libc exposes to other programs.  So
setting these kernel values might not change what you get all the way
through, have you tested it?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/