Re: [PATCH] bfa: fix leak of bfad_im_port_index on module unload

[Johannes Thumshirn]

On Fri, Jun 12, 2015 at 01:50:45AM +0300, Alexey Khoroshilov wrote:
> Resources allocated within bfad_im_port_index idr are not deallocated
> on module unload. The patch adds idr_destroy() in exit function.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Alexey Khoroshilov <khoroshilov@xxxxxxxxx>
> ---
>  drivers/scsi/bfa/bfad_im.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/scsi/bfa/bfad_im.c b/drivers/scsi/bfa/bfad_im.c
> index 7223b0006740..8367c11d554b 100644
> --- a/drivers/scsi/bfa/bfad_im.c
> +++ b/drivers/scsi/bfa/bfad_im.c
> @@ -851,6 +851,8 @@ bfad_im_module_exit(void)
>  
>  	if (bfad_im_scsi_vport_transport_template)
>  		fc_release_transport(bfad_im_scsi_vport_transport_template);
> +
> +	idr_destroy(&bfad_im_port_index);
>  }
>  
>  void
> -- 
> 1.9.1
> 

Reviewed-by: Johannes Thumshirn <jthumshirn@xxxxxxx>

-- 
Johannes Thumshirn                                       Storage
jthumshirn@xxxxxxx                             +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/