Re: [PATCH v5 17/21] libnvdimm: infrastructure for btt devices

From: Christoph Hellwig
Date: Thu Jun 11 2015 - 03:28:24 EST


On Wed, Jun 10, 2015 at 02:46:16PM -0400, Matthew Wilcox wrote:
> Don't screw up rw_page. The point of rw_page is to read or write a page
> cache page. It can sleep, and it indicates success by using the page
> flags. Don't try and scqueeze rw_bytes into it. If you want rw_bytes
> to be a queue operation, that's one thing, but don't mess with rw_page.

Oh, I forgot about the page manipulating nature. Yes, we'll need a different
operation in this case.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/