Re: [PATCH 3/4] mm: Defer flush of writable TLB entries

[Ingo Molnar]

* Mel Gorman <mgorman@xxxxxxx> wrote:

> +
> +	/*
> +	 * If the PTE was dirty then it's best to assume it's writable. The
> +	 * caller must use try_to_unmap_flush_dirty() or try_to_unmap_flush()
> +	 * before the page any IO is initiated.
> +	 */

Speling nit: "before the page any IO is initiated" does not parse for me.

> +			/*
> +			 * Page is dirty. Flush the TLB if a writable entry
> +			 * potentially exists to avoid CPU writes after IO
> +			 * starts and then write it out here
> +			 */

s/here/here.

or:

s/here/here:

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/