Re: [PATCH v5 4/5] block: loop: prepare for supporing direct IO

[Christoph Hellwig]

On Tue, Jun 09, 2015 at 09:49:25PM +0800, Ming Lei wrote:
> This patches provides two approaches for enabling direct IO
> from user space:
> 
> 	- userspace(such as losetup) can pass 'file' which is
> 	opened/fcntl as O_DIRECT
> 	- sysfs file is provided to run dio tests easily

I really don't think two interfaces are a good idea here.  The interface
for loop has always been that userspaces passes a FD and we use it,
so let's keep it that way.

And while we're at it please also send a patch for losetup so that we
can actually use the feature.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/