Re: [PATCH V2] regulator: core: fix constraints debug output

From: Stefan Wahren
Date: Tue Jun 09 2015 - 14:50:13 EST



> Mark Brown <broonie@xxxxxxxxxx> hat am 9. Juni 2015 um 20:00 geschrieben:
>
>
> On Wed, Jun 03, 2015 at 09:56:29PM +0000, Stefan Wahren wrote:
> > The line buffer for constraints debug isn't big enough to hold the output
> > in all cases. So fix the possible buffer overflow by the usage of the
> > scnprintf().
>
> If we know how much output we might produce then why not extend the
> buffer so we don't need to cut it off? The defensive programming is
> good but that seems a better fix.

I thought the intension was to keep the output in "one" line. If not i suggest
to increase the size to 160 bytes, which is sufficient for all cases.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/