Re: [PATCH RFC v2 1/2] hwspinlock: Introduce raw capability for hwspinlocks

From: Jeffrey Hugo
Date: Tue Jun 09 2015 - 13:00:06 EST


Two minor nits I noticed.

On 6/9/2015 10:23 AM, Lina Iyer wrote:
The hwspinlock framework, uses a s/w spin lock around the hw spinlock to
ensure that only process acquires the lock at any time. This is the most

Should this be "ensure that only one process"?

<snip>

Introduce hwcaps member for hwspinlock_device. The hwcaps represents the

Technically you added it to the hwspinlock struct, not hwspinlock_device. Mentioning that the hwcaps member was added to hwspinlock_device in the description here may be slightly confusing.

--
Jeffrey Hugo
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/