Re: [PATCH v2 1/2] ASoC: wm_adsp: Add code_probe and codec_remove stubs

From: Mark Brown
Date: Tue Jun 09 2015 - 12:01:12 EST


On Tue, Jun 09, 2015 at 04:16:56PM +0100, Richard Fitzgerald wrote:

> + ret = wm_adsp2_codec_probe(&priv->core.adsp[0], codec);
> + if (ret)
> + return ret;
> +

I'm still not a big fan of the double registration that's being done -
if nothing else the fact that it's not also factoring out the creation
of the DSP controls seems wrong.

Attachment: signature.asc
Description: Digital signature