Re: [PATCH] atm: use msecs_to_jiffies for conversions

From: David Miller
Date: Mon Jun 08 2015 - 18:54:42 EST


From: Nicholas Mc Guire <hofrat@xxxxxxxxx>
Date: Mon, 8 Jun 2015 21:16:28 +0200

> API compliance scanning with coccinelle flagged:
> ./drivers/atm/iphase.c:2621:4-20:
> WARNING: timeout (50) seems HZ dependent
>
> Numeric constants passed to schedule_timeout() make the effective
> timeout HZ dependent which does not seem intended.
> Fixed up by converting the constant to jiffies with msecs_to_jiffies()
> As this driver was introduced in the early 2.3 series it is most
> likely assuming HZ=100 so the constant 50 is converted to 500ms.
>
> Signed-off-by: Nicholas Mc Guire <hofrat@xxxxxxxxx>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/