Re: [PATCH 1/2] debugfs: support read-only and write-only bool types

[Greg KH]

On Fri, Jun 05, 2015 at 05:42:55PM +0100, Mark Brown wrote:
> On Fri, Jun 05, 2015 at 03:34:45PM +0100, Richard Fitzgerald wrote:
> 
> > +static ssize_t debugs_read_wo_file(struct file *file, char __user *buf,
> > +				   size_t count, loff_t *ppos)
> > +{
> > +	return -EACCES;
> > +}
> 
> Perhaps I'm missing something but shouldn't we be able to just omit
> empty functions like this (this seems to be what the other ro/wo debugfs
> defintions do otherwise these would already be there and it's what I'd
> expect)?


Yes you should.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/