Re: [PATCH] clockevents/drivers/timer-stm32: Fix build error spotted by kbuild test robot

From: Daniel Lezcano
Date: Mon Jun 08 2015 - 13:39:14 EST


On 06/07/2015 11:01 AM, Maxime Coquelin wrote:
This patch fixes below error spotted by kbuild test robot when building
with ARCH=ia64:

All error/warnings (new ones prefixed by >>):

drivers/clocksource/timer-stm32.c:38:28: error: field 'evtdev' has incomplete type

struct clock_event_device evtdev;
^

drivers/clocksource/timer-stm32.c:44:19: warning: 'enum clock_event_mode' declared inside parameter list

struct clock_event_device *evtdev)

The fix consists in making the STM32 timer depend on GENERIC_CLOCKEVENTS.

Reported-by: kbuild test robot <fengguang.wu@xxxxxxxxx>
Signed-off-by: Maxime Coquelin <mcoquelin.stm32@xxxxxxxxx>

Sounds good.

Thomas, Ingo ? do you will take this patch directly ? Or do you prefer I queue it and waiting for more fixes to come before sending a PR ?

Thanks
-- Daniel

--
<http://www.linaro.org/> Linaro.org â Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/