Re: [PATCH 08/10] x86/intel_rdt: Implement scheduling support for Intel RDT

[Vikas Shivappa]

On Mon, 8 Jun 2015, Thomas Gleixner wrote:

> On Sat, 6 Jun 2015, Thomas Gleixner wrote:
>
> > On Thu, 4 Jun 2015, Vikas Shivappa wrote:
> > > +static inline void intel_rdt_sched_in(void)
> > > +{
> > > +	if (static_key_false(&rdt_enable_key))
> > > +		__intel_rdt_sched_in();
> >
> > So if the enable_key is FALSE we call the RDT stuff? I might be
> > missing something important, but this does not make any sense and I
> > have to ask how that whole stuff has been tested.
>
> Bah. That static key API is really designed for maximal confusion. The
> above is correct, but a comment might not be the worst thing.

Ah yes, - its also tested with debug prints. Will add comment.

Thanks,
Vikas

> Thanks,
>
> 	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/