Re: [PATCH v2] drivers: of/base: move of_init to driver_init

[Grant Likely]

On Sun, 7 Jun 2015 19:29:17 -0500
, Rob Herring <robherring2@xxxxxxxxx>
 wrote:
> On Sun, Jun 7, 2015 at 2:05 AM, Grant Likely <grant.likely@xxxxxxxxxx> wrote:
> > On Tue, 19 May 2015 10:17:32 -0700
> > , Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> >  wrote:
> >> On Tue, May 19, 2015 at 01:29:16PM +0100, Sudeep Holla wrote:
> >> > Hi Rob/Greg,
> >> >
> >> > On 14/05/15 15:28, Sudeep Holla wrote:
> >> > >Commit 5590f3196b29 ("drivers/core/of: Add symlink to device-tree from
> >> > >devices with an OF node") adds the symlink `of_node` for each device
> >> > >pointing to it's device tree node while creating/initialising it.
> >> > >
> >> > >However the devicetree sysfs is created and setup in of_init which is
> >> > >executed at core_initcall level. For all the devices created before
> >> > >of_init, the following error is thrown:
> >> > >   "Error -2(-ENOENT) creating of_node link"
> >> > >
> >> > >Like many other components in driver model, initialize the sysfs support
> >> > >for OF/devicetree from driver_init so that it's ready before any devices
> >> > >are created.
> >> > >
> >> > >Fixes: 5590f3196b29 ("drivers/core/of: Add symlink to device-tree from
> >> > >   devices with an OF node")
> >> > >Suggested-by: Rob Herring <robh+dt@xxxxxxxxxx>
> >> > >Cc: Grant Likely <grant.likely@xxxxxxxxxx>
> >> > >Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> >> > >Cc: Pawel Moll <pawel.moll@xxxxxxx>
> >> > >Cc: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
> >> > >Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> >> > >Signed-off-by: Sudeep Holla <sudeep.holla@xxxxxxx>
> >> >
> >> > I assume one of you will pick this up if there are no further comments ?
> >>
> >> I will once things settle down...
> >
> > I've picked it up. Yell if you'd prefer to take it by your tree.
> 
> Greg already applied it. It just hit Linus' tree Sat.

Yeah, I only just saw that today. I'll drop it from mine.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/