RE: [PATCH v1] power: max17042_battery: add HEALTH and TEMP_* properties support

From: Pallala, Ramakrishna
Date: Sat May 23 2015 - 15:28:41 EST


> Hi,
>
> On Tue, May 05, 2015 at 05:10:32AM +0530, Ramakrishna Pallala wrote:
> > This patch adds the support for following battery properties to
> > max17042 fuel gauge driver.
> >
> > POWER_SUPPLY_PROP_TEMP_ALERT_MIN
> > POWER_SUPPLY_PROP_TEMP_ALERT_MAX
> > POWER_SUPPLY_PROP_TEMP_MIN
> > POWER_SUPPLY_PROP_TEMP_MAX
> > POWER_SUPPLY_PROP_HEALTH
> >
> > Signed-off-by: Ramakrishna Pallala <ramakrishna.pallala@xxxxxxxxx>
> > Reviewed-by: Krzysztof Kozlowski <k.kozlowski.k@xxxxxxxxx>
>
> The patch does not work for me:
>
> drivers/power/max17042_battery.c: In function
> âmax17042_get_battery_healthâ:
> drivers/power/max17042_battery.c:150:34: error:
> âMAX17042_VMAX_TOLERENCEâ undeclared (first use in this function)
> if (vbatt > chip->pdata->vmax + MAX17042_VMAX_TOLERENCE) {

My bad :( :(

I will fix it submit the patch v2

Thanks,
Ram
N‹§²æ¸›yú²X¬¶ÇvØ–)Þ{.nlj·¥Š{±‘êX§¶›¡Ü}©ž²ÆzÚj:+v‰¨¾«‘êZ+€Êzf£¢·hšˆ§~†­†Ûÿû®w¥¢¸?™¨è&¢)ßf”ùy§m…á«a¶Úÿ 0¶ìå