Re: [PATCH v6 3/6] arm64: Kprobes with single stepping support

[David Long]

On 05/22/15 12:54, Catalin Marinas wrote:
> On Fri, May 22, 2015 at 11:49:37AM -0400, William Cohen wrote:
> > On 05/22/2015 07:00 AM, Catalin Marinas wrote:
> > > Any plans to post an updated version with the "unexpected single-step
> > > error" fixed?
> >
> > The only place this issue with the "unexpected single-step error" has
> > been observed is with the arm64 kretporbe handler code calling kprobed
> > functions.  Experiments with kprobed functions being called in the
> > kprobe handlers showed that situation was handled appropriately.
> >
> > There is proposed fix to address the issue with the trampoline, the
> > attached patch.  This is modeled after the way that the x86 handles
> > the kretprobe.  The trampoline directly save and restores the
> > registers and uses a normal call to the kretprobe handler.  It
> > operates similarly to what you are suggesting above, but just for the
> > special case of the kretprobes.
>
> Thanks. I guess David will post a v7 series with this patch included and
> other comments addressed.
>
> BTW, I'll be on holiday for a week, back on the 1st of June. Hopefully
> this series gets some more reviews by then ;)

Yes, the v7 patch is in the works, with Will Cohen's trampoline fixes as 
well as your feedback.

-fl



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/