[PATCH] init/do_mounts: Add create_dev() failure log

From: Vishnu Pratap Singh
Date: Fri May 22 2015 - 08:39:39 EST


if create_dev() function fails to create the root mount device (/dev/root),
then it goes to panic as root device not found but there is no check/log
present in case of failure, So i have added the log in case it fails to create
the root device. It will help in debugging.

Signed-off-by: Vishnu Pratap Singh <vishnu.ps@xxxxxxxxxxx>
---
init/do_mounts.h | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/init/do_mounts.h b/init/do_mounts.h
index f5b978a..40c85e9 100644
--- a/init/do_mounts.h
+++ b/init/do_mounts.h
@@ -15,8 +15,12 @@ extern int root_mountflags;

static inline int create_dev(char *name, dev_t dev)
{
+ int ret;
sys_unlink(name);
- return sys_mknod(name, S_IFBLK|0600, new_encode_dev(dev));
+ ret = sys_mknod(name, S_IFBLK|0600, new_encode_dev(dev));
+ if(ret < 0)
+ printk(KERN_ERR " Failed to create %s device !! err: %d\n", name, ret);
+ return ret;
}

#if BITS_PER_LONG == 32
--
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/