Re: [PATCH v2 6/6] usb: chipidea: add work-around for Marvell HSIC PHY startup

[Peter Chen]

On Thu, May 21, 2015 at 09:54:20AM +0000, Peter Chen wrote:
>  
> > 
> > On Wed, May 20, 2015 at 10:13 PM, Peter Chen <peter.chen@xxxxxxxxxxxxx>
> > wrote:
> > > On Tue, May 19, 2015 at 09:10:05PM -0500, Rob Herring wrote:
> > >> The Marvell 28nm HSIC PHY requires the port to be forced to HS mode
> > >> after the port power is applied. This is done using the test mode in
> > >> the PORTSC register.
> > >>
> > >> As HSIC is always HS, this work-around should be safe to do with all
> > >> HSIC PHYs. If not, a flag can also be added.
> > >
> > > I think a flag is needed, not sure all vendors can work well with that.
> > 
> > Only i.MX6Sx uses HSIC in mainline. Is that something you can test? It would be
> > better to not add flags unless they are really needed.
> > Otherwise you end up with dozens of flags like SDHCI drivers have.
> > 
> 
> I will have a test for this, and show you the result later.
> 

Since imx6sx HSIC support is not supported at mainline, I tested
this sequence at internal branch, it does not affect imx6's
hsic function, I am ok with this patch.

Tested-by: Peter Chen <peter.chen@xxxxxxxxxxxxx>

> Peter
> ïïìï&ï~ï&ïïï+-ïïÝïïwïïËïïïmïbïïnïïïïïïÜ}ïïïÆzï&j:+vïïïïïïïzZ+ïï+zfïïïhïïï~ïïïïiïïïzïïwïïï?ïïïï&ï)ßf

-- 

Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/