Re: [PATCH 4/5] phy: cygnus: pcie: Add Cygnus PCIe PHY support

[Paul Bolle]

On Thu, 2015-05-21 at 16:53 -0700, Ray Jui wrote:
> Yes, I'll change the PCIe PHY driver to tristate in the Kconfig. Thanks!

To continue the discussion started in 2/5: this is my main beef with
built-in only code using module specific macros. It forces the reader of
the patch, and the code if it's already in the tree, to know the
intentions of the author. Did the author intend the code to be built-in
only or not?

And since most people appear not to be clairvoyant that's kind of hard
to do for most of us.


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/