Re: [PATCH 4/4] target: Drop unnecessary core_tpg_register TFO parameter

From: Hannes Reinecke
Date: Fri May 22 2015 - 04:00:43 EST


On 05/22/2015 09:06 AM, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx>
>
> This patch drops unnecessary target_core_fabric_ops parameter usage
> for core_tpg_register() during fabric driver TFO->fabric_make_tpg()
> se_portal_group creation callback execution.
>
> Instead, use the existing se_wwn->wwn_tf->tf_ops pointer to ensure
> fabric driver is really using the same TFO provided at module_init
> time.
>
> Also go ahead and drop the forward TFO declarations tree-wide, and
> handling the special case for iscsi-target discovery TPG.
>
> Cc: Christoph Hellwig <hch@xxxxxx>
> Signed-off-by: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx>
> ---
Reviewed-by: Hannes Reinecke <hare@xxxxxxx>

Cheers,

Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@xxxxxxx +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/