Re: [RFC PATCH 2/4] x86, mwaitt: introduce mwaitx idle with a configurable timer

[Thomas Gleixner]

On Thu, 21 May 2015, Borislav Petkov wrote:

> On Thu, May 21, 2015 at 10:56:32PM +0800, Huang Rui wrote:
> > Looks like good use case. Boris, could we try to implement it?
> 
> Andy had some suggestions on how to do it here:
> 
> https://lkml.kernel.org/r/555D3629.8080002@xxxxxxxxxx
> 
> which should be doable. Also, you'd probably need to set ECX[0]=0b too,
> so that MWAITX doesn't get woken up by interrupts while MWAIT-ing with
> interrupts disabled. I.e., this sequence:
> 
> cli
> rdtsc
> shove the computed timeout into ebx
> mov $2,%ecx				# this enables the timer and disables IRQs while MWAITing
> mwaitx
> sti

And the above sucks for udelay, because you disable interrupts for
random amounts of time.

Thanks,

	tglx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/