Re: [PATCH] regulator: core: fix constraints debug output

From: Stefan Wahren
Date: Thu May 21 2015 - 02:42:59 EST


Hi Joe,

> Joe Perches <joe@xxxxxxxxxxx> hat am 20. Mai 2015 um 22:35 geschrieben:
>
>
> On Wed, 2015-05-20 at 20:17 +0000, Stefan Wahren wrote:
> > In the case uV_offset is greater than 0 the debug output before
> > is accidentally overwritten. So take care of the output count.
>
> If you are going to take care, please change all of these
> sprintf calls to snprintf.

thanks for pointing out. I will create a second version.

But using scnprintf should be better here.

>
> The buf array may not be big enough [80] to hold the longest
> possible output string.
>

Stefan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/