Re: [PATCH v9 3/5] crypto: drbg - add async seeding operation

From: Herbert Xu
Date: Thu May 21 2015 - 02:36:37 EST


On Thu, May 21, 2015 at 08:10:13AM +0200, Stephan Mueller wrote:
>
> The cancel operation is needed as otherwise my drbg context handle will be
> removed by the crypto API during the sleep. That is the whole reason why
> wait_event_interruptible is used.
>
> So, even when using an uninterruptible sleep, the crypto API has no knowledge
> about it and I have to serialize the destruction code path with the async
> callback.

I understand. But if you use the uniterruptible version at least
you won't have to deal with bogus early returns.

The cancel by itself will *not* cause wait_event_interruptible
to return early. Somebody has to send it a signal for that to
happen.

Cheers,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/