Re: [PATCH 3/4] perf: Use pmu_events_map table to create event aliases

[Andi Kleen]

> +/*
> + * Return TRUE if the CPU identified by @vfm, @version, and @type
> + * matches the current CPU.  vfm refers to [Vendor, Family, Model],
> + *
> + * Return FALSE otherwise.
> + *
> + * For Powerpc, we only compare @version to the processor PVR.
> + */
> +bool arch_pmu_events_match_cpu(const char *vfm __maybe_unused,
> +				const char *version,
> +				const char *type __maybe_unused)
> +{
> +	char *cpustr;
> +	bool rc;
> +
> +	cpustr = get_cpu_str();
> +	rc = !strcmp(version, cpustr);


Surely against vfm not version
I think your mapfile is wrong if that works?

That's the Intel format:

.vfm = "GenuineIntel-6-3E",
        .version = "V16",
        .type = "core",
        .table = pme_IvyTown_core


-Andi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/