Re: [PATCH] block: Use BIT macro from include/linux/bitops.h

From: Jagan Teki
Date: Wed May 20 2015 - 15:41:48 EST


On 21 May 2015 at 00:52, Jens Axboe <axboe@xxxxxxxxx> wrote:
> On 05/18/2015 01:14 PM, Jagan Teki wrote:
>>
>> Replace (1 << nr) to BIT(nr) where nr = 0, 1, 2 .... 31
>
>
> I don't like it, I think it hurts readability.

What do you mean by don't like, using kernel defined macro instead of
numerical assignments huts readability?

thanks!
--
Jagan Teki,
Openedev.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/