Re: [PATCH] perf: fix wrong DEBUG configuration

[Martin LiÅka]

This is a multi-part message in MIME format.
On 05/20/2015 04:55 PM, Ingo Molnar wrote:
> * Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:
>
> > Em Wed, May 20, 2015 at 03:29:37PM +0200, Martin LiÅka escreveu:
> > > On 05/20/2015 03:17 PM, Arnaldo Carvalho de Melo wrote:
> > > > Em Wed, May 20, 2015 at 03:07:39PM +0200, Martin LiÅka escreveu:
> > > > > Currently, GCC optimizes -O6 same as -O3 level. Right optimize debugging
> > > > > experience is given by passing -Og to compiler.
> >
> > > > Is this is this -Og available in old gcc versions? When was it
> > > > introduced? Do you know?
> >
> > > GCC 4.8.0 is the first version capable of the option: https://gcc.gnu.org/gcc-4.8/changes.html.
> > > That can be problematic, which GCC version do you support in linux/perf?
> >
> > So the rule has been: What are the kernel requirements for the
> > toolchain? tools/perf/ should build with that.
>
> So we could use -Og if it works, like Kbuild does it:
>
>          KBUILD_CFLAGS += $(call cc-option,-mno-fp-ret-in-387)
>
> the 'cc-option' Make function does some magic of silently calling GCC
> with that option and observing the result.
>
> See:
>
>    scripts/Kbuild.include:cc-option = $(call try-run,\
>
> et al.
>
> Thanks,
>
> 	Ingo

Hi.

I am sorry, I did mistake in understanding of DEBUG variable.
Following patch should be fixed, except missing auto-detection
of -Og option.

Unfortunately, following hunk does not work, no -Ox is added to CFLAGS?

--  CFLAGS += -Og
++  CFLAGS += $(call cc-option,-Og,-O0)


Thanks,
Martin