Re: [PATCH 06/11] KVM: x86: pass kvm_mmu_page to gfn_to_rmap

From: Paolo Bonzini
Date: Wed May 20 2015 - 05:07:42 EST




On 20/05/2015 10:30, Xiao Guangrong wrote:
>> This is always available, and we can use the role to look up the right
>> memslots array.
>
> How about pass role instead of sp so that it can be used if no sp is
> available?

I can surely do that instead, but I'm not sure why one would have a role
and not an sp.

If you do not have an sp, you probably should instead use
kvm_vcpu_gfn_to_memslot and __gfn_to_rmap. See for example
rmap_write_protect.

I pushed the work to an "smm" branch of kvm.git, so that you can see the
result.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/