Re: [PATCH] x86, cpuinfo x86_model_id whitespace cleanup

[Joe Perches]

iOn Tue, 2015-05-19 at 13:16 -0700, Andy Lutomirski wrote:
> On Tue, May 19, 2015 at 12:22 PM, Borislav Petkov <bp@xxxxxxxxx> wrote:
> > On Tue, May 19, 2015 at 11:44:41AM -0700, Andy Lutomirski wrote:
> >> On May 19, 2015 11:13 AM, "Borislav Petkov" <bp@xxxxxxxxx> wrote:
> >> >
> >> > On Tue, May 19, 2015 at 01:25:59PM -0400, Brian Gerst wrote:
> >> > > Using strlcpy in this manner could fail if it does larger than byte
> >> > > copies and they overlap.
> >> >
> >> > Why?

I think this is traditionally handled by specifying that
the strcpy strings may not overlap, so the suggested

+	strlcpy(c->x86_model_id, strim(c->x86_model_id), 48);

isn't good code.

A temporary intermediate buffer is required.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/