Re: [PATCH v3 2/2] PM / Runtime: Add pm_runtime_enable_recursive

From: Alan Stern
Date: Tue May 19 2015 - 13:49:26 EST


On Tue, 19 May 2015, Tomeu Vizoso wrote:

> This function makes less cumbersome to enable runtime PM in a device and
> its descendants.
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@xxxxxxxxxxxxx>

I don't see the point of this. In the scenario you have in mind, are
the device and all its descendants registered by the same
subsystem/driver? If they are, can't the subsystem/driver code enable
runtime PM for each of them when they are registered, by adding a
single call in the right spot?

If they don't all belong to the same subsystem/driver, who is going to
call your pm_runtime_enable_recursive routine? No single caller will
have the right to enable runtime PM for all these devices.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/