Re: [RESEND][PATCH] Bluetooth: Make request workqueue freezable

From: Takashi Iwai
Date: Tue May 19 2015 - 13:13:21 EST


At Tue, 19 May 2015 10:26:46 -0400 (EDT),
Alan Stern wrote:
>
> > > > Of just have request_firmware()
> > > > actually sleep until userspace is ready. Seriously, why is
> > > > request_firmware not just sleeping for us.
>
> It won't work. The request_firmware call is part of the probe
> sequence, which in turn is part of the resume sequence. Userspace
> doesn't start running again until the resume sequence is finished. If
> request_firmware waited for userspace, it would hang.

Note that the recent request_firmware() doesn't need the user-space
invocation (unless the fallback is explicitly enabled) but loads the
file directly. And, request_firmware() for the cached data is valid
to be called in the resume path.


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/