Re: [PATCH 1/1] [930672e8693a] Task 10 of the Eudyptula Challenge

From: Greg Kroah-Hartman
Date: Tue May 19 2015 - 10:19:00 EST


On Tue, May 19, 2015 at 01:50:10AM -0300, Douglas Figueiredo wrote:
> From: douglasbsf <eng.douglasfigueiredo@xxxxxxxxx>

We need a "real" name here, and in the signed-off-by line.

Also fix up your subject line like mentioned.

>
> Fixed Coding Style Problem in drivers/staging/wlan-ng/prism2fw.c
>
> Signed-off-by: douglasbsf <eng.douglasfigueiredo@xxxxxxxxx>
> ---
> drivers/staging/wlan-ng/prism2fw.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging/wlan-ng/prism2fw.c
> index 9408644..27ead4c 100644
> --- a/drivers/staging/wlan-ng/prism2fw.c
> +++ b/drivers/staging/wlan-ng/prism2fw.c
> @@ -708,7 +708,9 @@ static int plugimage(struct imgchunk *fchunk, unsigned int nfchunks,
> continue;
> }
>
> - /* Validate plug address against chunk data and identify chunk */
> + /* Validate plug address against
> + * chunk data and identify chunk
> + */

Please use the correct indentation for multi-line comments as well.

Please fix up and resend, I can't take this as-is.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/