Re: mod_devicetable: Make dmi_strmatch.substr const char *

[David Woodhouse]

On Mon, 2015-05-18 at 17:07 -0700, Joe Perches wrote:
> 
> changed dmi_strmatch.substr from char * to char[79];
> 
> Changing it back to const char * would shrink an x86-64
> defconfig more than 100KB.
> 
> $ size vmlinux.old vmlinux.new
>     text    data     bss      dec    hex filename
> 11941725 1825624 1085440 14852789 e2a2b5 vmlinux.old
> 11921172 1730648 1085440 14737260 e0df6c vmlinux.new
> 
> modpost has changed a bit since 2008, is it's time to change it back?

Does the match table stuff still work if you do that? I thought the
point in changing to an array was to make the table extraction do the
right thing because it can't follow pointers...

-- 
dwmw2


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/