Re: [PATCH 1/4] modsign: Abort modules_install when signing fails

[Mimi Zohar]

On Fri, 2015-05-15 at 17:52 +0100, David Woodhouse wrote:
> Signed-off-by: David Woodhouse <David.Woodhouse@xxxxxxxxx>

I assume the patch descriptions will be added before being upstreamed.  

> ---
>  scripts/Makefile.modinst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/Makefile.modinst b/scripts/Makefile.modinst
> index e48a4e9..07650ee 100644
> --- a/scripts/Makefile.modinst
> +++ b/scripts/Makefile.modinst
> @@ -22,7 +22,7 @@ quiet_cmd_modules_install = INSTALL $@
>      mkdir -p $(2) ; \
>      cp $@ $(2) ; \
>      $(mod_strip_cmd) $(2)/$(notdir $@) ; \
> -    $(mod_sign_cmd) $(2)/$(notdir $@) $(patsubst %,|| true,$(KBUILD_EXTMOD)) ; \
> +    $(mod_sign_cmd) $(2)/$(notdir $@) $(patsubst %,|| true,$(KBUILD_EXTMOD)) && \
>      $(mod_compress_cmd) $(2)/$(notdir $@)

With this patch, as expected the modules_install aborted on failure.  Is
there any way to capture the reason for the failure?   In my case,
dropping the '-j <num>' option resolved the problem.

Mimi

>  # Modules built outside the kernel source tree go into extra by default

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/