Re: [PATCH v2] perf: Separate the tests and tools in installation

From: Arnaldo Carvalho de Melo
Date: Mon May 18 2015 - 16:22:48 EST


Em Mon, May 18, 2015 at 11:37:27AM -0700, Nam T. Nguyen escreveu:
> This refactors out install-bin to install-tests and install-tools so
> that downstream could opt to only install the tools, and not the tests.
>
> Change-Id: Idfac38ca6fcb3057baeda416591473c9d86dffe9

What is this 'Change-Id': tag? Something specific to the Chromium
project? I'll keep it, but wonder if what would be the sense for this
in the Linux kernel source repo...

- Arnaldo

> Signed-off-by: Nam T. Nguyen <namnguyen@xxxxxxxxxxxx>
> ---
> Changes from v1:
>
> * Keep original target dependencies
>
> tools/perf/Makefile.perf | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> index 7257e7e..2cb98db 100644
> --- a/tools/perf/Makefile.perf
> +++ b/tools/perf/Makefile.perf
> @@ -830,7 +830,7 @@ check: $(OUTPUT)common-cmds.h
>
> install-gtk:
>
> -install-bin: all install-gtk
> +install-tools: all install-gtk
> $(call QUIET_INSTALL, binaries) \
> $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(bindir_SQ)'; \
> $(INSTALL) $(OUTPUT)perf '$(DESTDIR_SQ)$(bindir_SQ)'; \
> @@ -858,12 +858,16 @@ endif
> $(call QUIET_INSTALL, perf_completion-script) \
> $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(sysconfdir_SQ)/bash_completion.d'; \
> $(INSTALL) perf-completion.sh '$(DESTDIR_SQ)$(sysconfdir_SQ)/bash_completion.d/perf'
> +
> +install-tests: all install-gtk
> $(call QUIET_INSTALL, tests) \
> $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests'; \
> $(INSTALL) tests/attr.py '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests'; \
> $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/attr'; \
> $(INSTALL) tests/attr/* '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/attr'
>
> +install-bin: install-tools install-tests
> +
> install: install-bin try-install-man install-traceevent-plugins
>
> install-python_ext:
> --
> 2.2.0.rc0.207.ga3a616c
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/