Re: [Linux-nvdimm] [PATCH v2 01/20] e820, efi: add ACPI 6.0 persistent memory types

From: Andy Lutomirski
Date: Mon May 18 2015 - 15:28:56 EST


On May 16, 2015 12:48 AM, "Dan Williams" <dan.j.williams@xxxxxxxxx> wrote:
>
> On Fri, May 15, 2015 at 8:43 AM, Jeff Moyer <jmoyer@xxxxxxxxxx> wrote:
> > Dan Williams <dan.j.williams@xxxxxxxxx> writes:
> >
> >> @@ -919,10 +920,31 @@ static inline const char *e820_type_to_string(int e820_type)
> >> case E820_NVS: return "ACPI Non-volatile Storage";
> >> case E820_UNUSABLE: return "Unusable memory";
> >> case E820_PRAM: return "Persistent RAM";
> >> + case E820_PMEM: return "Persistent I/O Memory";
> >
> > Minor nit, but nobody refers to this stuff as persistent I/O memory.
> > I've heard it referred to as persistent memory or storage class memory.
> > In the end, I doubt it matters.
>
> Had we not polluted the waters with E820_PRAM I would have chosen
> "Persistent Memory", but as we now need to support both I'd assume
> they need different names.

We could reverse it and call E820_PRAM "legacy persistent RAM" or
something similar.

</bikeshed>

>
> > Acked-by: Jeff Moyer <jmoyer@xxxxxxxxxx>
>
> Thanks Jeff.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/