Re: [PATCH] radeon: Deinline indirect register accessor functions

[Denys Vlasenko]

On 05/18/2015 08:06 PM, Christian KÃnig wrote:
> I'm actually surprised how often people come along with that. The last time we tried this it caused a noticeable performance drop.
> 
> Basic problem is that this line:
>> +    if ((reg < rdev->rmmio_size || reg < RADEON_MIN_MMIO_SIZE) && !always_indirect)
> optimizes away in most of the cases which reduces the call to a readl which is way faster than the spinlock path.
> 
> So this is a NAK,


Fair enough.

I'm preparing a v2 where the fast branch of r100_mm_{r,w}reg() will stay inlined.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/