Re: [RFC PATCH v3 08/37] bpf tools: Define basic interface

[Alexei Starovoitov]

On 5/17/15 3:56 AM, Wang Nan wrote:
> bpf_open_object() and bpf_close_object() are open and close function of
> eBPF object files. 'struct bpf_object' will be handler of one object
> file. Its internal structure is hide to user.
>
> Signed-off-by: Wang Nan <wangnan0@xxxxxxxxxx>
> ---
...
> +
> +struct bpf_object *bpf_open_object(const char *path)
> +{
> +	return NULL;
> +}
> +
> +void bpf_close_object(struct bpf_object *object)
> +{
> +	return 0;
> +}

I'm not a fan of introducing empty helpers. I would
squash it with the patch that actually adds meat to it.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/