Re: [PATCH] Staging: rtl8192e: Timer setup using macro rather assignment

[Sudip Mukherjee]

On Mon, May 18, 2015 at 02:44:15PM +0000, DHANAPAL, GNANACHANDRAN (G.) wrote:
> setup_timer is used for timer parameter setup rather than direct
> assignment
> 
> Signed-off-by: Gnanachandran Dhanapal <gdhanapa@xxxxxxxxxxx>

your From: name and Signed-off-by: names are not matching. They should
be same.

> ---
<snip>
> --- a/drivers/staging/rtl8192e/rtllib_module.c
> +++ b/drivers/staging/rtl8192e/rtllib_module.c
> @@ -59,9 +59,8 @@ EXPORT_SYMBOL(rt_global_debug_component);
>  
>  void _setup_timer(struct timer_list *ptimer, void *fun, unsigned long data)
>  {
> -	ptimer->function = fun;
> -	ptimer->data = data;
>  	init_timer(ptimer);
> +	setup_timer(ptimer, fun, data);
setup_timer is calling __setup_timer which is again calling __init_timer
here we already have an init_timer which is also calling __init_timer.
so now __init_timer gets executed two times for one timer. 

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/