Re: [PATCH] bfa: deinline __bfa_trc() and __bfa_trc32()

From: Denys Vlasenko
Date: Mon May 18 2015 - 09:02:36 EST


On 05/18/2015 02:58 PM, Guenter Roeck wrote:
> On 05/18/2015 02:18 AM, Denys Vlasenko wrote:
>> __bfa_trc() compiles to 115 bytes of machine code.
>> With this .config: http://busybox.net/~vda/kernel_config
>> there are 1494 calls of __bfa_trc().
>>
>> __bfa_trc32() is very similar, so it is uninlined too.
>> However, it appears to be unused, therefore this patch
>> ifdefs it out.
>>
> Why not just remove it ?

I'm not familiar with the code, figured maintainers know better.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/