Re: [PATCH V3 09/13] selftests, powerpc: Add test for DSCR value inheritence across fork

From: Anton Blanchard
Date: Mon May 18 2015 - 01:10:15 EST


Hi Anshuman,

Thanks for getting these testcases into the kernel.

> This patch adds a test to verify that the changed DSCR value inside
> any process would be inherited to it's child process across the fork
> system call.

One issue I do notice (a bug in my original test cases too), is that we
don't restore the DSCR on exit. I'm not sure we need to go to the
trouble of saving and restoring it, but we should at least get it back
to 0 when done.

Also a tiny nit, no need for a newline in perror():

open() failed
: Permission denied

With those changes you can add:

Signed-off-by: Anton Blanchard <anton@xxxxxxxxx>

to the patches based on my testcases.

Anton
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/